Skip to content

feat(spotlight): add search by services #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 9, 2025

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/c/projects/QOV/boards/56?selectedIssue=QOV-74

  • Favorites and recents services views

PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Make it work, make it right, make it fast

@RemiBonnet RemiBonnet force-pushed the feat/search-spotlight-QOV-74 branch from 8f172dd to e95e778 Compare April 9, 2025 03:14
Copy link

nx-cloud bot commented Apr 9, 2025

View your CI Pipeline Execution ↗ for commit 0e98e3c.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 53s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 1m 17s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 1m 12s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-09 08:50:56 UTC

@RemiBonnet RemiBonnet marked this pull request as ready for review April 9, 2025 03:15
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 49.47917% with 97 lines in your changes missing coverage. Please review.

Project coverage is 53.55%. Comparing base (b232673) to head (0e98e3c).
Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
.../spotlight/feature/src/lib/spotlight/spotlight.tsx 39.74% 42 Missing and 5 partials ⚠️
...tlight/feature/src/lib/sub-command/sub-command.tsx 40.74% 29 Missing and 3 partials ⚠️
...oks/use-favorite-services/use-favorite-services.ts 80.00% 0 Missing and 6 partials ⚠️
...ibs/pages/application/src/lib/page-application.tsx 0.00% 6 Missing ⚠️
...b/hooks/use-recent-services/use-recent-services.ts 83.33% 0 Missing and 3 partials ⚠️
...i/src/lib/components/command-menu/command-menu.tsx 33.33% 2 Missing ⚠️
...ib/feature/spotlight-trigger/spotlight-trigger.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1860      +/-   ##
===========================================
+ Coverage    53.44%   53.55%   +0.10%     
===========================================
  Files         1018     1022       +4     
  Lines        14499    14675     +176     
  Branches      4224     4266      +42     
===========================================
+ Hits          7749     7859     +110     
- Misses        5310     5351      +41     
- Partials      1440     1465      +25     
Flag Coverage Δ
unittests 53.55% <49.47%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet merged commit ad41ad8 into staging Apr 9, 2025
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/search-spotlight-QOV-74 branch April 9, 2025 09:01
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.183.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant