Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slope threshold parameter #384

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

edumur
Copy link
Contributor

@edumur edumur commented Nov 22, 2024

Dear qcodes people,

I hope to have done the git things correctly this time.
This pull request simply add two parameters to control the slope threshold.

Thanks.

Étienne.

@edumur
Copy link
Contributor Author

edumur commented Nov 28, 2024

Dear all,

Should I do something else about this pull request?

Thanks.

@jenshnielsen
Copy link
Collaborator

@edumur Sorry for the delay. Has been very busy with other stuff. Left some comments inline. Would you also be able to look into why the tests are failing in CI

auto-merge was automatically disabled December 11, 2024 14:53

Head branch was pushed to by a user without write access

@edumur
Copy link
Contributor Author

edumur commented Dec 11, 2024

@jenshnielsen No worries ;)

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 10.48%. Comparing base (988100c) to head (4dcc99f).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...codes_contrib_drivers/drivers/Tektronix/FCA3100.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   10.49%   10.48%   -0.01%     
==========================================
  Files         138      138              
  Lines       18378    18380       +2     
==========================================
  Hits         1928     1928              
- Misses      16450    16452       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edumur
Copy link
Contributor Author

edumur commented Jan 29, 2025

Is something else missing?

@jenshnielsen
Copy link
Collaborator

Sorry I am just really running behind on reviewing prs

@jenshnielsen jenshnielsen added this pull request to the merge queue Jan 29, 2025
Merged via the queue into QCoDeS:main with commit 5f942f2 Jan 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants