-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add slope threshold parameter #384
Conversation
Dear all, Should I do something else about this pull request? Thanks. |
@edumur Sorry for the delay. Has been very busy with other stuff. Left some comments inline. Would you also be able to look into why the tests are failing in CI |
Head branch was pushed to by a user without write access
@jenshnielsen No worries ;) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 10.49% 10.48% -0.01%
==========================================
Files 138 138
Lines 18378 18380 +2
==========================================
Hits 1928 1928
- Misses 16450 16452 +2 ☔ View full report in Codecov by Sentry. |
Is something else missing? |
Sorry I am just really running behind on reviewing prs |
Dear qcodes people,
I hope to have done the git things correctly this time.
This pull request simply add two parameters to control the slope threshold.
Thanks.
Étienne.