Extend Andor iDus/DU camera driver #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready to go for now. I'll postpone work on hardware triggers until I have more time. Do we add a newspiece here in this repo as well? |
|
Could a maintainer please review this? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly extends the capabilities of the Andor iDus camera driver. A fairly large part of the SDK is now covered.
Since the central data parameter,
ccd_data, is dynamic in that it returns different shapes of arrays depending on the acqusition and read modes, I dropped thespectrummoniker. However, this also means that backwards compatibility is broken. If this is something we want to avoid, one could add aDelegateParameterthat issues a deprecation warning when called.To Do
Test hardware triggeringDeferred to a later point in time.
acquired_pixelsneeds to be aware of downsampling that, e.g., image mode performs.acquisition in kinetics mode with the cosmic ray filter turned on errors.This seems to be a camera feature, so users should handle it.
Missing Features / Needs testing
run till abortmode. This requires some async work, but would be nice to have since taking a single picture at a time (1 or 2d) has quite a lot of communication overhead, meaning the fastest update rate I could achieve was ~200 ms.