Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio queue manager, solution for #292 #462

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Audio queue manager, solution for #292 #462

wants to merge 19 commits into from

Conversation

sockheadrps
Copy link
Contributor

@sockheadrps sockheadrps commented Jul 9, 2024 •
edited
Loading

Description

Closes #292
I added queuemanager.py to ext.sounds, which is a class that wraps the audio player and exposes common music queue functionality that allows users to add sound files to a queue and gives them an API to interact with that queue to control audio,

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

sockheadrps and others added 13 commits April 23, 2023 13:46
@sockheadrps
Added the ability to set rate and channels on Sound
a6a0b18
@sockheadrps
Added the ability to set rate and channels on Sound
20ba986
@sockheadrps
typo in docs
03e52ba
@sockheadrps
typo in docs
2bf418c
@sockheadrps
add to changelog
215e5b2
@sockheadrps
Added tinytag dependency to retrieve audio file metadata
e7e2047 
This allows for automatic detetction of local audio files' sample rate and audio channels so the files play correctly
@sockheadrps
Updated Sounds Docs to reflect auto-detect of sample rate etc
a2176dc
@sockheadrps
Merge branch 'master' into sounds_setters
16834d7
@IAmTomahawkx
Merge branch 'master' into sounds_setters
7bb21c2
@sockheadrps
Added new dependency for resolving stereo channels and sample rate fr…
0c46ba7 
…om audio files. Added setters for rate and channel to expose them incase the meta data is incorrect.
@sockheadrps
Merge remote-tracking branch 'upstream/maintain/2.x' into sound_setters
62ff356
@sockheadrps
Added new dependency for resolving stereo channels and sample rate fr…
1f12f4a 
…om audio files. Added setters for rate and channel to expose them incase the meta data is incorrect.
@sockheadrps
Added queuemanager to sounds.ext
a935e80
chillymosh
chillymosh reviewed Jul 9, 2024
View reviewed changes
twitchio/ext/sounds/queuemanager.py Outdated Show resolved Hide resolved
twitchio/ext/sounds/queuemanager.py Outdated Show resolved Hide resolved
twitchio/ext/sounds/queuemanager.py Outdated Show resolved Hide resolved
twitchio/ext/sounds/queuemanager.py Outdated Show resolved Hide resolved
@sockheadrps
Fixed docstrings, removed unnecessary async definitions for methods t…
2a739ed 
…hat didn't need to be coroutines, updated example
chillymosh
chillymosh reviewed Jul 10, 2024
View reviewed changes
twitchio/ext/sounds/queuemanager.py Outdated Show resolved Hide resolved
twitchio/ext/sounds/queuemanager.py Outdated Show resolved Hide resolved
@sockheadrps sockheadrps requested a review from chillymosh July 18, 2024 05:21
@chillymosh chillymosh requested a review from EvieePy August 1, 2024 20:07
@chillymosh chillymosh added 2.0 TwitchIO 2.0 EXT: sounds labels Aug 1, 2024
@sockheadrps sockheadrps mentioned this pull request Aug 26, 2024
Closed
@LostLuma LostLuma changed the base branch from master to main January 28, 2025 09:52
@EvieePy EvieePy added the Stale/Outdated Issues that relate to an older release but kept for reference. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillymosh chillymosh Awaiting requested review from chillymosh

@EvieePy EvieePy Awaiting requested review from EvieePy

Assignees
No one assigned
Labels
2.0 TwitchIO 2.0 EXT: sounds Stale/Outdated Issues that relate to an older release but kept for reference.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip Track
4 participants
@sockheadrps @chillymosh @EvieePy @IAmTomahawkx