Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bollinger Band code needs some minor rework #3

Open
RichardDale opened this issue Dec 3, 2019 · 1 comment
Open

Bollinger Band code needs some minor rework #3

RichardDale opened this issue Dec 3, 2019 · 1 comment

Comments

@RichardDale
Copy link

Inside Bollinger Bands Tutorial.py, there's some minor rework required.

item[’30 Day STD’] = item[‘Adj Close’].rolling(window=20).std()

should become

item[’30 Day STD’] = item[‘Adj Close’].rolling(window=20).std(ddof=0)
(this is because the standard deviation is being calculated against a population, not a sample)

Hope that is of assistance.

Cheers,
Richard.

@PyDataBlog
Copy link
Owner

@RichardDale how about making a pull request with the fix? I will credit you in the post as soon as it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants