Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: PULS API data missmatch between /haltestellen and /abfahrten endpoints #11

Open
BolverBlitz opened this issue Jan 4, 2025 · 0 comments
Labels
0.5.0 bug Something isn't working VAG (Upstream) Caused by VAG dependencies; requires upstream fix.
Milestone

Comments

@BolverBlitz
Copy link
Member

A year ago i wrote them that the /haltestellen endpoint claimed there is a UBahn product at "Stühleinshöhstr" while they fixed it in this endpoint, the UBahn is still servicing this station acording to the /abfahrten endpoint.

https://start.vag.de/dm/api/v1/haltestellen/VAG?name=B%C3%A4renschanze

{
  "Metadata": {
    "Version": "Puls-API-v1.2.3",
    "Timestamp": "2025-01-04T17:34:47+01:00"
  },
  "Haltestellen": [
    {
      "Haltestellenname": "Bärenschanze (Nürnberg)",
      "VAGKennung": "BAER-S",
      "VGNKennung": 702,
      "Longitude": 11.0509280698124,
      "Latitude": 49.4523900886399,
      "Produkte": "Bus,UBahn"
    },
    {
      "Haltestellenname": "Bärenschanze (Nürnberg)",
      "VAGKennung": "BS",
      "VGNKennung": 702,
      "Longitude": 11.0509280698124,
      "Latitude": 49.4523900886399,
      "Produkte": "Bus,UBahn"
    }
  ]
}

https://start.vag.de/dm/api/v1/abfahrten/VAG/BS

{
  "Metadata": {
    "Version": "Puls-API-v1.2.3",
    "Timestamp": "2025-01-04T17:33:10+01:00"
  },
  "Haltestellenname": "Stühleinshöhstr. (Lauf a. d. Pegnitz)",
  "VAGKennung": "BS",
  "VGNKennung": 7021,
  "Abfahrten": [
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:1",
      "Richtung": "Richtung2",
      "Richtungstext": "Fürth Hardhöhe",
      "AbfahrtszeitSoll": "2025-01-04T17:33:33+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:34:34+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05042,
      "Latitude": 49.45270806,
      "Fahrtnummer": 1027718,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "31103",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "1"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:2",
      "Richtung": "Richtung1",
      "Richtungstext": "Langwasser Süd",
      "AbfahrtszeitSoll": "2025-01-04T17:36:13+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:36:19+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05118889,
      "Latitude": 49.45234,
      "Fahrtnummer": 1003142,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "30940",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "2"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:1",
      "Richtung": "Richtung2",
      "Richtungstext": "Fürth Hardhöhe",
      "AbfahrtszeitSoll": "2025-01-04T17:39:33+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:40:03+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05042,
      "Latitude": 49.45270806,
      "Fahrtnummer": 1010137,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "30103",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "1"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:2",
      "Richtung": "Richtung1",
      "Richtungstext": "Langwasser Süd",
      "AbfahrtszeitSoll": "2025-01-04T17:43:13+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:43:13+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05118889,
      "Latitude": 49.45234,
      "Fahrtnummer": 1014511,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "31040",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "2"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:1",
      "Richtung": "Richtung2",
      "Richtungstext": "Fürth Hardhöhe",
      "AbfahrtszeitSoll": "2025-01-04T17:46:33+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:46:33+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05042,
      "Latitude": 49.45270806,
      "Fahrtnummer": 1010291,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "30803",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "1"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:2",
      "Richtung": "Richtung1",
      "Richtungstext": "Langwasser Süd",
      "AbfahrtszeitSoll": "2025-01-04T17:49:13+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:49:13+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05118889,
      "Latitude": 49.45234,
      "Fahrtnummer": 1005005,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "30740",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "2"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:1",
      "Richtung": "Richtung2",
      "Richtungstext": "Fürth Hardhöhe",
      "AbfahrtszeitSoll": "2025-01-04T17:53:33+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:53:33+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05042,
      "Latitude": 49.45270806,
      "Fahrtnummer": 1023499,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "31203",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "1"
    },
    {
      "Linienname": "U1",
      "Haltepunkt": "BS:2",
      "Richtung": "Richtung1",
      "Richtungstext": "Langwasser Süd",
      "AbfahrtszeitSoll": "2025-01-04T17:56:13+01:00",
      "AbfahrtszeitIst": "2025-01-04T17:56:13+01:00",
      "Produkt": "UBahn",
      "Longitude": 11.05118889,
      "Latitude": 49.45234,
      "Fahrtnummer": 1014578,
      "Betriebstag": "2025-01-04",
      "Fahrtartnummer": 1,
      "Fahrzeugnummer": "30440",
      "Besetzgrad": "Unbekannt",
      "Prognose": true,
      "HaltesteigText": "2"
    }
  ]
}

Found by one of the new tests for 0.5.0

8) Compare station key to VAG API Haltestellenname
       should match key "Bärenschanze" to Haltestellenname:

      AssertionError: expected 'Stühleinshöhstr.' to equal 'Bärenschanze'
      + expected - actual

      -Stühleinshöhstr.
      +Bärenschanze

      at Context.<anonymous> (test\compare_static_ubahn_stations_with_puls.js:25:38)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
@BolverBlitz BolverBlitz added bug Something isn't working VAG (Upstream) Caused by VAG dependencies; requires upstream fix. 0.5.0 labels Jan 4, 2025
@BolverBlitz BolverBlitz added this to the Version 0.5.0 milestone Jan 4, 2025
BolverBlitz added a commit that referenced this issue Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5.0 bug Something isn't working VAG (Upstream) Caused by VAG dependencies; requires upstream fix.
Projects
None yet
Development

No branches or pull requests

1 participant