Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Tidy commhosp variable #1045

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Bug - Tidy commhosp variable #1045

merged 7 commits into from
Feb 7, 2025

Conversation

Jennit07
Copy link
Collaborator

Closes #1030

The variable commhosp is typically Y/N string format, however for outpatients and A&E data this was pulling from boxi as 1/0. This tidies this up to make things consistent. I also added this for A&E data as the variable was available in the datamart but was not being pulled through

@Jennit07 Jennit07 requested a review from lizihao-anu January 20, 2025 10:01
@Jennit07 Jennit07 self-assigned this Jan 20, 2025

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

SPSS

These words are not needed and should be removed anomymous datas scoial spss

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:Public-Health-Scotland/source-linkage-files.git repository
on the bug_commhosp branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/12865533907/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (313) from .github/actions/spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:fullstack/dict/fullstack.txt 419 3 3
cspell:k8s/dict/k8s.txt 153 4 1
cspell:php/dict/php.txt 1689 4
cspell:node/dict/node.txt 891 3 1
cspell:npm/dict/npm.txt 302 3

Consider adding them (in .github/workflows/spelling.yml) in jobs:/spelling: for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries: |
          cspell:fullstack/dict/fullstack.txt
          cspell:k8s/dict/k8s.txt
          cspell:php/dict/php.txt
          cspell:node/dict/node.txt
          cspell:npm/dict/npm.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 3

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jennit07
Copy link
Collaborator Author

Update - more work required on this PR

NEWS.md Outdated Show resolved Hide resolved
@Jennit07 Jennit07 requested a review from lizihao-anu February 3, 2025 16:06
@Jennit07
Copy link
Collaborator Author

Jennit07 commented Feb 3, 2025

Needs testing at read in but this temp fix can be used in the march update. We can update this again at source when the work in boxi has passed.

Ready for review

@Jennit07 Jennit07 merged commit c5dfa10 into mar25-update Feb 7, 2025
3 of 4 checks passed
@Jennit07 Jennit07 deleted the bug_commhosp branch February 7, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants