-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug - Tidy commhosp
variable
#1045
Conversation
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)SPSS These words are not needed and should be removedanomymous datas scoial spssTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/12865533907/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (313) from .github/actions/spelling/expect.txt and unrecognized words (1)
Consider adding them (in with:
extra_dictionaries: |
cspell:fullstack/dict/fullstack.txt
cspell:k8s/dict/k8s.txt
cspell:php/dict/php.txt
cspell:node/dict/node.txt
cspell:npm/dict/npm.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Update - more work required on this PR |
Needs testing at read in but this temp fix can be used in the march update. We can update this again at source when the work in boxi has passed. Ready for review |
Closes #1030
The variable
commhosp
is typically Y/N string format, however for outpatients and A&E data this was pulling from boxi as 1/0. This tidies this up to make things consistent. I also added this for A&E data as the variable was available in the datamart but was not being pulled through