-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E1 second graph addition #2
Open
MahriScot
wants to merge
103
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…language attribute to English for screen readers.
Additional code added to: * app.R (added tidyverse library) * data_preperation.R (added distinct financial years for graph) * E1_server.R * E1_ui.R
…dded same code as for graph 1 that removes unnecessary buttons from modebar
I wanted the axis range to be "0:whatever the highest value is across ALL years" for every year's graph. Things I tried, that didn't work, included: # rangemode = "tozero" # tick0 = 0 # range = list(c(0, 300), round(max(E1_data$rate_per_1000_population), 10)) ----- this one ensures all graphs have the same range of 0-300 days but the graph wasn't starting at 0 (As bed days are going up each year, "round(...,10)" sets the xaxis as 10 more than whatever the new data shows as the maximum value)
…es" to "E1_area_types"
…xt csv file. (Some are still to be worked on)
…now readable at an angle)
…sv and assigned appropriately
…ut alt text & Scotland Hub for now.
…ead before any other script is ran.
…E1 chart descriptions to refer to mental health specialties.
… and testing adding graph titles
… of Ayrshire & Arran.
…P2, P3, P4, S2, S5)
…object for alt text rather than having alt text manually entered. Objects are pulled from .csv file in indicator_alt_text.R (T1 won't save to git at present, will try again)
…ribility to previous years.
…ed font size from H2 to H3
… out, test code also removed from E1.
…d are in the same formatted text box at the bottom of each page.
…and S5) and creating titles and boxes for graphs and data. Note no data or graphs yet, and keeping infographic at bottom of each page for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicator E1's second graph code. Graph's title and fluidity of the graph when users zoom in or change screen size is still to be worked on.