ZipExtensionWrapper class added with unit tests. #693
Conversation
Teigler
requested review from
niklasstich and
andreasweishaupt
and removed request for
niklasstich
Pull Request Test Coverage Report for Build 12946571648Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
defnegoncu
force-pushed
the
zipextension
branch
from
778c366 to
5e178be
Compare
CreateFromDirectoryAsync_NoWritePermission_ThrowsUnauthorizedAccessException updated with NSubstitute.
This reverts commit 1e59c91.
Fix von CreateFromDirectoryAsync_NoWritePermission_ThrowsUnauthorizedAccessException() test using NSubstitute.
|
|
||
| namespace DataAccessTest.Extensions; | ||
| [TestFixture] | ||
| public class ZipExtensionUnitTest |
There was a problem hiding this comment.
Sollte dann ZipExtensionsWrapperUt heißen.
| { | ||
| _mockFileSystem = new MockFileSystem(); | ||
| } | ||
| public ZipExtensionWrapper CreateZipExtensionWrapper(IFileSystem? fileSystem = null) |
|
|
||
| namespace DataAccess.Extensions; | ||
| /// <inheritdoc cref="ZipExtension"/> | ||
| public class ZipExtensionWrapper |
There was a problem hiding this comment.
Da die Klasse, auf die sich der Wrapper bezieht ZipExtensions heißt, sollte auch der Wrapper ZipExtensionsWrapper heißen.
| FileSystem = fileSystem; | ||
| } | ||
|
|
||
| /// <inheritdoc cref="ZipExtension.GetZipArchive"/> |
There was a problem hiding this comment.
Die doc kann nicht einfach so übernommen werden, da es den Parameter für das FileSystem im Wrapper nicht mehr gibt.
| return memoryStream; | ||
| } | ||
|
|
||
| private static MemoryStream CreateMemmoryStreamWithZipArchive() |
There was a problem hiding this comment.
*CreateMemoryStreamWithZipArchive()
| /// Implementing tested with OpenRead. It would be better if a mock file would be constructed using the TestingHelpers that we are not allowed to access. | ||
| /// </summary> | ||
| [Test] | ||
| public void GetZipArchiveAccessIsDenied_ThrowsUnauthorizedAccessException() |
There was a problem hiding this comment.
*GetZipArchive_AccessIsDenied_ThrowsUnauthorizedAccessException()
Besser lesbar, da die zu testende Methode vor dem ersten Unterstrich steht.
| /// Implementing tested with OpenRead. It would be better if a mock file would be constructed using the TestingHelpers that we are not allowed to access. | ||
| /// </summary> | ||
| [Test] | ||
| public void GetZipArchiveFileCannotBeRead_ThrowsIOException() |
There was a problem hiding this comment.
*GetZipArchive_FileCannotBeRead_ThrowsIOException()
| @@ -0,0 +1,648 @@ | |||
| using DataAccess.Extensions; | |||
There was a problem hiding this comment.
Tests, die aus plattformspezifischen Gründen fehlschlagen, müssen mit einer plattformunabhängigen Möglichkeit, Pfade zu erstellen, überarbeitet werden.
Pfade in den Tests müssen in Abhängigkeit des aktuellen Betriebssystems erstellt werde.
Zu finden in DataAccess/Extensions/ZipExtensionWrapper