Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SilkroadLinux.py #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

demon36
Copy link

@demon36 demon36 commented Sep 16, 2016

fix for error : "must be char, not int"

fix for error : "must be char, not int"
@Ryan-ProjectHax
Copy link
Contributor

I decided to open the original EXE and the patched EXE in Olly and it does indeed write a single byte without using chr(). It would not have worked if it had ever written more than one byte.

Original:

00420C42  |.  83F8 FF       CMP EAX,-1
00420C45  |.  75 19         JNE SHORT 00420C60
00420C47  |.  68 148F4A00   PUSH OFFSET 004A8F14                     ; /Procname = "TransmitFile"

Patched:

00420C42  |.  83F8 FF       CMP EAX,-1
00420C45  \.  EB 19         JMP SHORT 00420C60
00420C47  /.  68 148F4A00   PUSH OFFSET 004A8F14                     ; /Procname = "TransmitFile"

@demon36
Copy link
Author

demon36 commented Sep 17, 2016

maybe there is a problem in my python installation, becase i do get an
error when applying the patch without chr()

On Sat, Sep 17, 2016 at 1:07 AM, Ryan notifications@github.com wrote:

I decided to open the original EXE and the patched EXE in Olly and it does
indeed write a single byte without using chr(). It would not have worked
if it had ever written more than one byte.

Original:

00420C42 |. 83F8 FF CMP EAX,-1
00420C45 |. 75 19 JNE SHORT 00420C60
00420C47 |. 68 148F4A00 PUSH OFFSET 004A8F14 ; /Procname = "TransmitFile"

Patched:

00420C42 |. 83F8 FF CMP EAX,-1
00420C45 . EB 19 JMP SHORT 00420C60
00420C47 /. 68 148F4A00 PUSH OFFSET 004A8F14 ; /Procname = "TransmitFile"


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHRSBOPyFC8YSKNEPZxG8xw5N0Xew7MQks5qqyEsgaJpZM4J_and
.

@Ryan-ProjectHax
Copy link
Contributor

I wrote it for Python 3 and only tested with that. Is it possible you are using Python 2? What is the error you are seeing?

@demon36
Copy link
Author

demon36 commented Sep 22, 2016

im using python 2.7.6,
you could apply the edit if its safer to use chr(),
thx for the patch anyway it worked well with a private server installation

On Sat, Sep 17, 2016 at 8:48 PM, Ryan notifications@github.com wrote:

I wrote it for Python 3 and only tested with that. Is it possible you are
using Python 2? What is the error you are seeing?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHRSBLTlMw5oO30EeG6pzky3Tk6anUWEks5qrDYWgaJpZM4J_and
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants