[PAYSHIP-3135] Refactor CapturePayPalOrderCommandHandler #1310
+3,017
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt75
force-pushed
the
refacto/PAYSHIP-3135-ps17
branch
2 times, most recently
from
75a9170 to
a95f48c
Compare
Matt75
force-pushed
the
refacto/PAYSHIP-3135-ps17
branch
from
a95f48c to
a99cbe9
Compare
Matt75
force-pushed
the
refacto/PAYSHIP-3135-ps17
branch
from
5eab322 to
03fb69d
Compare
PSebou
previously approved these changes
Jan 29, 2025
Matt75
commented
Jan 30, 2025
There was a problem hiding this comment.
Catching exceptions without logging or handling them properly can make debugging significantly harder. Instead of returning an empty array silently, consider logging the error or rethrowing it so that issues can be detected and diagnosed more easily. If suppressing the error is intentional, adding a comment explaining why would help future maintainers understand the decision.
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
seiwan
requested changes
Jan 31, 2025
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/Order/CommandHandler/CapturePayPalOrderCommandHandler.php
Outdated
Show resolved
Hide resolved
seiwan
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.