Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt upgraded installs to recent changes #659

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Dec 28, 2023

Questions Answers
Description? Implements required database changes for recent 9.0.0 PRs.
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test? Run upgrade from 8.1.x to develop and check if it ran correctly. I ran everything in database admin and works correctly.

List of PRs

Copy link
Contributor

@ShaiMagal ShaiMagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AureRita AureRita self-assigned this Jan 10, 2024
@AureRita
Copy link
Contributor

Hi @Hlavtox

Thank you for this PR, I tested it and I see something :

recording.49.webm

It seems to not load the change that you give with the first three PR

About the last one, all seems to works except that you can search warehouse :
image

And your stock isn't calculated with Product return as you can see :

recording.50.webm

Thank you

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jan 10, 2024

@AureRita

  • You are not seeing changes because you are upgrading to 8.1.3 and this PR concerns update to develop.
  • About the last one, all seems to works except that you can search warehouse : - no idea what you mean by this, but not related to this PR. Btw, I get There are no results matching your query "AdminWarehouses". on both 8.1.x and develop.
  • And your stock isn't calculated with Product return as you can see : - again, nothing to do with my PR.

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jan 10, 2024

I see what you mean, but yeah, typing nonsense into the URL bar will get you this message. On all prestashop versions. I don't know what it has to do with my PR.

Snímek obrazovky 2024-01-10 174411

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen with @Hlavtox ,

At the moment the module can't be tested with an upgrade to 9.0.0, because of this error PrestaShop/PrestaShop#35029

Although, the queries that are added to the module have been tested manually on phpmyadmin. And it is OK. All the queries are well executed.

Screenshot 2024-01-11 at 15 39 39

It is OK on QA side ✅

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jan 11, 2024

Thank you @florine2623! :-)

@Hlavtox Hlavtox merged commit 7f61c4c into PrestaShop:dev Jan 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants