Introduce Twig function asset() #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quetzacoalt91
commented
Feb 19, 2025
| @@ -664,13 +670,15 @@ public function getTwig() | |||
| $loader->addPath(realpath(__DIR__ . '/..') . '/views/templates', 'ModuleAutoUpgrade'); | |||
| $twig = new Environment($loader); | |||
| $twig->addExtension(new TransFilterExtension3($this->getTranslator())); | |||
| $twig->addExtension(new AssetFunctionExtension3($this)); | |||
There was a problem hiding this comment.
Having the container as a parameter triggers the autowiring on the storybook side. Because of its string parameters, it cannot complete and makes the startup fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asset()available on Twig when used in a Symfony environment. This replaces the current implementation where we always have to think about sending the base path from all controller.