Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list-all-zones in multi-backend configuration involving LMDB #15238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

I noticed recently that a multi-backend configuration with LMDB as the last backend would not display all domains in pdnsutil list-all-zones (and possibly other operations).

This is caused by the LMDB backend replacing the data instead of appending to it.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Doing this causes incomplete information to be returned in multi-backend
configuration.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13591519276

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 43 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.503%

Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 83.66%
pdns/distributor.hh 2 51.86%
pdns/tcpiohandler.cc 2 68.18%
pdns/ws-auth.cc 2 80.79%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/recursordist/test-syncres_cc1.cc 5 89.91%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.5%
pdns/recursordist/syncres.cc 7 80.14%
ext/json11/json11.cpp 12 62.72%
Totals Coverage Status
Change from base Build 13588225536: 0.02%
Covered Lines: 127657
Relevant Lines: 166926

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants