-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix allow-from markup/link #15201
Open
jsoref
wants to merge
7
commits into
PowerDNS:master
Choose a base branch
from
jsoref:docs-allow-from
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miodvallat
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Pull Request Test Coverage Report for Build 13513480535Details
💛 - Coveralls |
miodvallat
reviewed
Feb 24, 2025
pdns/recursordist/docs/security-advisories/powerdns-advisory-2014-01.rst
Outdated
Show resolved
Hide resolved
c3a191b
to
d9ba623
Compare
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
track to git map generated using: ```sh git log --all --pretty=raw | egrep '^commit |git-svn-id:' > git-svn-map ``` entries to rewrite selected using: ```sh grep '/changeset/' pre-4.0.rst | perl -pe 's/`/\n/' | grep /changeset/ > seek ``` rewrite perl generated using approximately: ```sh echo '$/=undef;' for a in $( cat seek | perl -pe ' s/\s*//; s/ <.*/ /; ' ); do echo 's,commit '$a' <http://wiki.powerdns.com/projects/trac/changeset/'$a'>,<'$( grep -B1 "@$a" git-svn-map|head -1 )',;' done ``` An extra pass was required to fix up the links to proper `commit SHA <.../SHA>` notation. Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
80803c4
to
66c4a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
https://doc.powerdns.com/authoritative/security-advisories/powerdns-advisory-2015-01.html renders:
The goal was for
allow-from
to be a link to recursor/settingsAlso, the files are now (and have been for a while!)
.rst
, not.md
....Checklist
I have: