Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix allow-from markup/link #15201

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 21, 2025

Short description

https://doc.powerdns.com/authoritative/security-advisories/powerdns-advisory-2015-01.html renders:

Workaround: Run your Recursor under a supervisor. Exposure can be limited by configuring the `allow-from <../recursor/settings.md#allow-from>`__ setting so only trusted users can query your nameserver. There is no workaround for the Authoritative server.

The goal was for allow-from to be a link to recursor/settings

Also, the files are now (and have been for a while!) .rst, not .md....

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@coveralls
Copy link

coveralls commented Feb 21, 2025

Pull Request Test Coverage Report for Build 13513480535

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.498%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/syncres.cc 1 80.28%
ext/json11/json11.cpp 2 62.72%
pdns/distributor.hh 2 51.86%
pdns/recursordist/sortlist.cc 2 72.94%
pdns/ws-auth.cc 2 80.79%
pdns/fstrm_logger.cc 3 58.37%
pdns/remote_logger.cc 3 56.95%
pdns/tsigverifier.cc 3 77.22%
pdns/dnsdistdist/dnsdist-tcp.cc 4 75.76%
pdns/dnspacket.cc 4 70.86%
Totals Coverage Status
Change from base Build 13495935494: -0.03%
Covered Lines: 127627
Relevant Lines: 166897

💛 - Coveralls

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
track to git map generated using:
```sh
git log --all --pretty=raw |
  egrep '^commit |git-svn-id:' > git-svn-map
```

entries to rewrite selected using:
```sh
grep '/changeset/' pre-4.0.rst |
  perl -pe 's/`/\n/' |
  grep /changeset/ > seek
```

rewrite perl generated using approximately:
```sh
  echo '$/=undef;'
  for a in $(
    cat seek |
      perl -pe '
        s/\s*//;
        s/ <.*/ /;
      '
  ); do
    echo 's,commit '$a' <http://wiki.powerdns.com/projects/trac/changeset/'$a'>,<'$(
    grep -B1 "@$a" git-svn-map|head -1
  )',;'
  done
```

An extra pass was required to fix up the links to proper `commit SHA <.../SHA>` notation.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants