Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored resource_helpers to include create_outer_model function #59

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Refactored resource_helpers to include create_outer_model function #59

merged 1 commit into from
Jul 19, 2024

Conversation

maxachis
Copy link

@maxachis maxachis commented Jul 19, 2024 •
edited
Loading

Fixes

Description

  • Updated Resources to use create_outer_model function for data_sources_outer_model and search_result_outer_model.

Testing

  • Run tests in tests directory

Performance

  • Performance impact marginal.

Docs

  • Not applicable.

@maxachis
Refactored resource_helpers to include create_outer_model function an…
3150254 
…d updated DataSources.py to use it for data_sources_outer_model and search_result_outer_model.
@maxachis maxachis self-assigned this Jul 19, 2024
@maxachis maxachis marked this pull request as ready for review July 19, 2024 20:03
@maxachis maxachis merged commit 33fb091 into dev Jul 19, 2024
10 of 11 checks passed
@maxachis maxachis deleted the mc_issue_364_consolidate_body_response_formatting branch July 19, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-chamberlain josh-chamberlain Awaiting requested review from josh-chamberlain josh-chamberlain is a code owner

Assignees

@maxachis maxachis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxachis