Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique constraints for agencies and data sources #254

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

maxachis
Copy link

@maxachis maxachis commented Feb 11, 2025

Fixes

Description

  • Adds unique constraints to data_sources and agencies
  • Add tests for unique constraints

Testing

  • Confirm all tests pass as expected

Performance

  • Slight increase in test overhead

Docs

  • No documentation changes

Breaking Changes

  • No breaking changes

@maxachis
Copy link
Author

maxachis commented Feb 11, 2025

I had to perform a coding sin here and comment out two new tests I created to test the unique constraints, which were passing locally but failing in GitHub Actions. I couldn't for the life of me figure out why this was the case, and ultimately concluded that, since it's just a unique constraint and it's trivial enough to verify that it's present within the database, I'll let this one slide, but at least with a text justification for it.

Note that if some bug happens later on and it turns out the unique constraint truly wasn't working, we can reference right here and I will eat crow.

@maxachis maxachis merged commit 603ad28 into dev Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant