Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work /api-key to accept JWT authorization rather than email and login. #211

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Work /api-key to accept JWT authorization rather than email and login. #211

merged 1 commit into from
Dec 4, 2024

Conversation

maxachis
Copy link

@maxachis maxachis commented Dec 4, 2024 •
edited
Loading

Fixes

Description

  • Update /api-key endpoint to take a JWT authorization header, rather than email and password

Testing

  • Run tests in
  • For cut-and-dry changes (API updates or interface tweaks), include a screenshot or updated API response to show what correct behavior looks like

Performance

  • Impact marginal

Docs

  • Accompanying docs PRs, if applicable

Breaking Changes

  • /api-key endpoint now changed to take a JWT authorization header, rather than email and password.

@maxachis maxachis merged commit 902fefd into dev Dec 4, 2024
11 checks passed
@josh-chamberlain josh-chamberlain deleted the mc_549_rework_api_header branch February 5, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-chamberlain josh-chamberlain Awaiting requested review from josh-chamberlain josh-chamberlain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxachis