Refactor Access Logic: #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve standardization of access token creation and parsing * Remove redundant logic * Improve standardization of error responses when parsing access tokens * Extract some logic to separate functions Add `test_bad_request_api_key_not_allowed` Add `test_bad_request_jwt_not_allowed` Add logic for getting specific authorization header Rename `test_bad_request_authorization` to `test_bad_request_malformed_header` Complete `test_bad_request_missing_header` Add `test_bad_request_endpoints_with_headers_have_bad_request_response_spec` Standardize response info to `/refresh-session`, `/user-profile`, `/validate-email` Remove unused modules and imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
test_bad_request_api_key_not_allowedtest_bad_request_jwt_not_allowedtest_bad_request_authorizationtotest_bad_request_malformed_headertest_bad_request_missing_headertest_bad_request_endpoints_with_headers_have_bad_request_response_spec/refresh-session,/user-profile,/validate-emailTesting
testsdirectory, and confirm all function as expectedPerformance
Docs
Breaking Changes