Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend README.txt to reflect actual state. #601

Open
wants to merge 1 commit into
base: MOODLE_404_STABLE
Choose a base branch
from

Conversation

lucaboesch
Copy link
Contributor

No description provided.

branches. Use the latest STABLE branch for development or installation.
The current stable branch is MOODLE_400_STABLE, and supports Moodle 4.0 and up.
The current stable branch is MOODLE_404_STABLE, and supports Moodle 4.4 and up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely true. The current stable branch (aside from naming) is MOODLE_401_STABLE. It supports Moodle 4.1 through 4.4.
MOODLE_404_STABLE is the current development branch, for the next stable release, and supports Moodle 4.4 and targeting 4.5.

@lucaboesch
Copy link
Contributor Author

My point being: the current one (both MOODLE_401_STABLE as well as in MOODLE_400_STABLE branch, maybe the one in MOODLE_404_STABLE, too) ought to be amended.

@lucaboesch lucaboesch force-pushed the readmechanges branch 5 times, most recently from c71551d to 16c5506 Compare February 19, 2025 22:10
@lucaboesch
Copy link
Contributor Author

I think it is accurate now.
Also, this pull request lets your Plugin CI tests turn green again.

@lucaboesch
Copy link
Contributor Author

Rebased to MOODLE_404_STABLE branch

@mchurchward
Copy link
Contributor

What's the change to "tests/custom_completion_test" for?
Also, there is now a conflict with the CI file.

@lucaboesch
Copy link
Contributor Author

lucaboesch commented Feb 21, 2025

_provider() classes have to be static now, @mchurchward
In this pull request, also main (Moodle 5.0) is tested by CI.

@lucaboesch
Copy link
Contributor Author

Rebased to MOODLE_404_STABLE branch

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. But...
Can you leave this PR to be just for the README?
Create a separate issue for the tests - I'm guessing that is something for 4.6? Since my CI isn't failing on that prior to that.
Don't include your CI changes yet. I will create a new development branch after this release to include main. Otherwise, we run the risk of the release branch failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants