-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend README.txt to reflect actual state. #601
base: MOODLE_404_STABLE
Are you sure you want to change the base?
Conversation
branches. Use the latest STABLE branch for development or installation. | ||
The current stable branch is MOODLE_400_STABLE, and supports Moodle 4.0 and up. | ||
The current stable branch is MOODLE_404_STABLE, and supports Moodle 4.4 and up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not completely true. The current stable branch (aside from naming) is MOODLE_401_STABLE. It supports Moodle 4.1 through 4.4.
MOODLE_404_STABLE is the current development branch, for the next stable release, and supports Moodle 4.4 and targeting 4.5.
My point being: the current one (both MOODLE_401_STABLE as well as in MOODLE_400_STABLE branch, maybe the one in MOODLE_404_STABLE, too) ought to be amended. |
c71551d
to
16c5506
Compare
I think it is accurate now. |
16c5506
to
24a96b0
Compare
Rebased to MOODLE_404_STABLE branch |
What's the change to "tests/custom_completion_test" for? |
_provider() classes have to be static now, @mchurchward |
24a96b0
to
24daa6e
Compare
Rebased to MOODLE_404_STABLE branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. But...
Can you leave this PR to be just for the README?
Create a separate issue for the tests - I'm guessing that is something for 4.6? Since my CI isn't failing on that prior to that.
Don't include your CI changes yet. I will create a new development branch after this release to include main. Otherwise, we run the risk of the release branch failing.
No description provided.