Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionnaire: make Summary page display more intuitive #589

Closed

Conversation

toanlamt
Copy link
Contributor

@toanlamt toanlamt commented Aug 15, 2024

E.g. In this questionnaire, they are 151 questionnaire responses, but 198 question responses. As only complete questionnaire responses are analyzed (the data is exported and cleaned), showing more question responses than questionnaire responses in the summary is confusing.

E.g. here's a view of a recent case:
image

If we could make the view selectable, this would clean up the summary and make a bit more sense.

Drop-down: "All responses" [198 in this case]; "Full submissions" [151 in this case]; "Responses not submitted" [47],
Consistent language to delineate between question-specific responses and full/complete questionnaire submissions.
Correct the 'total' and percentages on the visual graphs depending on the view.
E.g. here's a view after improvement
image

@mchurchward
Copy link
Contributor

Can you rebase with the latest MOODLE_401_STABLE? I just fixed the CI.

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR still includes commits from other changes that this one. The PR needs to just include the one(s) for this PR.
You need to pull the latest MOODLE_401_STABLE locally, then rebase your branch on top of that.

@tailetan
Copy link
Contributor

rebased with MOODLE_401_STABLE, @mchurchward

@mchurchward mchurchward self-requested a review August 29, 2024 18:05
mchurchward
mchurchward previously approved these changes Aug 29, 2024
@mchurchward mchurchward dismissed their stale review August 29, 2024 18:06

Re-reviewing

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions.

@mchurchward
Copy link
Contributor

I have replaces this with a new #621 and rebased it with MOODLE_404_STABLE.

@mchurchward
Copy link
Contributor

Rebased with MOODLE_404_STABLE in this PR.
Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants