Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt mobile code to ionic 7 #581

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

dpalou
Copy link
Contributor

@dpalou dpalou commented Jul 22, 2024

In this PR I'm removing the ionic3 code (the ionic5 app was released on 2021 so it should be safe to remove it).

I also created a new latest template to use the new Ionic syntax for inputs. The old syntax still works in the 4.4 version of the app (ionic 7), but it will stop working in the 4.5 version (ionic 8) so some inputs could be wrongly aligned without these changes. To make it easier to review the code, in the first commit I duplicate the template (no changes done in the HTML) and then I apply the changes in a new commit.

Finally, I also removed the usage of core-course-module-description component for newer app versions, it is deprecated and will be removed in a future version of the app. It should have been removed already, but we kept it in the app because some plugins still use it.

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. So, just confirming. These changes will work on all current Moodle 4 releases, correct?

@dpalou
Copy link
Contributor Author

dpalou commented Aug 22, 2024

Hi @mchurchward ,

yes, almost all of the changes are in Mustache templates that are only used for the app, they don't have any effect in Moodle LMS. The only change done in PHP code is a variable value, so it's safe.

The plugin will stop working in apps still using Ionic 3 (because I removed the ionic3 templates), but we upgraded to Ionic 5 more than 3 years ago so it should be safe to remove it.

@mchurchward mchurchward merged commit 154d3ff into PoetOS:MOODLE_401_STABLE Aug 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants