Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate placekey-py against newest version of H3 Library #41

Open
jarredSafegraph opened this issue Oct 14, 2024 · 5 comments
Open

Validate placekey-py against newest version of H3 Library #41

jarredSafegraph opened this issue Oct 14, 2024 · 5 comments

Comments

@jarredSafegraph
Copy link
Collaborator

Users have reported latest version of placekey-py are not working with latest versions of H3.

@eric-leap
Copy link

@jarredSafegraph Indeed. I temporarily solved this by specifying pip install h3<4.0.0 before I install placekey. But it seems like placekey should be updated to reflect the updated version of h3.

@bohrarohan
Copy link

Thanks @eric-leap
We too were able to resolve issues(short-term_solution) using your suggestion, and installing h3 v2.7.7 🚀

@jarredSafegraph
Copy link
Collaborator Author

Hey,

Sorry for the delay on this one. In taking a look at the changes to the H3 library and wanting to ensure we maintain functionality in our library, we have decided to lock on h3<4,>=3.6 for the time being. If you are working with the newest version of H3, do let me know, and I can see about making the necessary changes.

Collecting h3<4,>=3.6.1 (from placekey)
  Downloading h3-3.7.7-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (4.9 kB)

@medhatgayed
Copy link
Contributor

Hi @jarredSafegraph I also am having problems getting placekey-py to work nicely with h3-py, specifically I need a version of h3-py that allows me to convert H3 cells to GeoJSON/Polygons and AFAIK this was only possible in h3-py since version 4 which is incompatible with all versions of placekey-py.

@jarredSafegraph
Copy link
Collaborator Author

@medhatgayed
That is correct for the time being. We are weighing the path forward at the moment: either splitting API and Spatial functionality from API or something to that end. Would you mind sharing more about your use case for the H3 / spatial side? If you would rather share with me directly, you can email me at jparrett@safegraph.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants