Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version : 2.3.0 #185

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Version : 2.3.0 #185

merged 5 commits into from
Nov 26, 2024

Conversation

Petterpx
Copy link
Owner

@Petterpx Petterpx commented Nov 24, 2024

Summary by Sourcery

通过在各种接口和类中引入FxBuilderDsl注解来增强DSL支持。将FxBasisHelper更改为抽象类以提高抽象性。修复英文README中的表格格式以提高可读性。

增强功能:

  • 在各种接口和类中引入FxBuilderDsl注解以改善DSL支持。
  • 将FxBasisHelper从开放类更改为抽象类以提高抽象性。

文档:

  • 修复README_EN.md中的表格格式以提高可读性。
Original summary in English

Summary by Sourcery

Enhance the DSL support by introducing the FxBuilderDsl annotation to various interfaces and classes. Change FxBasisHelper to an abstract class to improve abstraction. Fix table formatting in the English README for better readability.

Enhancements:

  • Introduce FxBuilderDsl annotation to various interfaces and classes to improve DSL support.
  • Change FxBasisHelper from an open class to an abstract class for better abstraction.

Documentation:

  • Fix table formatting in README_EN.md for better readability.

Copy link
Contributor

sourcery-ai bot commented Nov 24, 2024

Reviewer's Guide by Sourcery

此PR引入了版本2.3.0,包含两个主要更改:为更好的类型安全性在构建器模式中添加了DSL标记注解,以及在简单应用示例中实现了新的活动生命周期回调。

更新的FxBasisHelper类图

classDiagram
    class FxBasisHelper {
        -layoutId: Int
    }
    note for FxBasisHelper "FxBasisHelper现在是抽象的"
Loading

文件级更改

更改 详情 文件
添加了新的DSL标记注解以提高Kotlin DSL的类型安全性
  • 创建了新的@FxBuilderDsl注解与@DslMarker
  • 将@FxBuilderDsl应用于代码库中的各种接口和类
  • 更新了ProGuard规则以保留新的DSL标记注解
  • 将FxBasisHelper从开放类更改为抽象类
floatingx/src/main/java/com/petterp/floatingx/assist/helper/FxBasisHelper.kt
floatingx/src/main/java/com/petterp/floatingx/assist/helper/FxAppHelper.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxConfigStorage.kt
floatingx/src/main/java/com/petterp/floatingx/assist/FxAnimation.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxPermissionInterceptor.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxProxyTagActivityLifecycle.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxTouchListener.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxViewLifecycle.kt
floatingx/proguard-floatingx.pro
在简单应用示例中添加了活动生命周期回调实现
  • 实现了带有onDestroyed回调的IFxProxyTagActivityLifecycle接口
  • 为简单应用添加了活动生命周期监控功能
app/src/main/java/com/petterp/floatingx/app/kotlin/FxAppSimple.kt

提示和命令

与Sourcery互动

  • 触发新审查: 在拉取请求上评论@sourcery-ai review
  • 继续讨论: 直接回复Sourcery的审查评论。
  • 从审查评论生成GitHub问题: 通过回复审查评论请求Sourcery创建一个问题。
  • 生成拉取请求标题: 在拉取请求标题的任何地方写@sourcery-ai以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何地方写@sourcery-ai summary以随时生成PR摘要。您也可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审查功能,如Sourcery生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查指令。
  • 调整其他审查设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This PR introduces version 2.3.0 with two main changes: the addition of a DSL marker annotation for better type safety in the builder pattern, and implementation of a new activity lifecycle callback in the simple app example.

Updated class diagram for FxBasisHelper

classDiagram
    class FxBasisHelper {
        -layoutId: Int
    }
    note for FxBasisHelper "FxBasisHelper is now abstract"
Loading

File-Level Changes

Change Details Files
Added a new DSL marker annotation to improve Kotlin DSL type safety
  • Created new @FxBuilderDsl annotation with @DslMarker
  • Applied @FxBuilderDsl to various interfaces and classes in the codebase
  • Updated ProGuard rules to keep the new DSL marker annotation
  • Changed FxBasisHelper from open to abstract class
floatingx/src/main/java/com/petterp/floatingx/assist/helper/FxBasisHelper.kt
floatingx/src/main/java/com/petterp/floatingx/assist/helper/FxAppHelper.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxConfigStorage.kt
floatingx/src/main/java/com/petterp/floatingx/assist/FxAnimation.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxPermissionInterceptor.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxProxyTagActivityLifecycle.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxTouchListener.kt
floatingx/src/main/java/com/petterp/floatingx/listener/IFxViewLifecycle.kt
floatingx/proguard-floatingx.pro
Added activity lifecycle callback implementation in the simple app example
  • Implemented IFxProxyTagActivityLifecycle interface with onDestroyed callback
  • Added activity lifecycle monitoring capability to the simple app
app/src/main/java/com/petterp/floatingx/app/kotlin/FxAppSimple.kt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Petterpx - 我已经审查了你的更改,它们看起来很棒!

这是我在审查期间查看的内容
  • 🟡 一般问题:发现1个问题
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery对开源项目免费 - 如果你喜欢我们的审查,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击👍或👎,我将使用反馈来改进你的审查。
Original comment in English

Hey @Petterpx - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -46,6 +49,12 @@ object FxAppSimple {
)
},
)
setTagActivityLifecycle(object :IFxProxyTagActivityLifecycle{
override fun onDestroyed(activity: Activity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议: 删除仅调用super的空覆盖

此覆盖除了super调用外没有添加任何功能。要么添加清理逻辑,要么完全删除覆盖

            setTagActivityLifecycle(object :IFxProxyTagActivityLifecycle{
            })
Original comment in English

suggestion: Remove empty override that only calls super

This override adds no functionality beyond the super call. Either add cleanup logic or remove the override entirely

            setTagActivityLifecycle(object :IFxProxyTagActivityLifecycle{
            })

@Petterpx Petterpx merged commit c74e73d into main Nov 26, 2024
2 checks passed
@Petterpx Petterpx deleted the feat/2.3.0 branch November 26, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant