-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version : 2.3.0 #185
Version : 2.3.0 #185
Conversation
Reviewer's Guide by Sourcery此PR引入了版本2.3.0,包含两个主要更改:为更好的类型安全性在构建器模式中添加了DSL标记注解,以及在简单应用示例中实现了新的活动生命周期回调。 更新的FxBasisHelper类图classDiagram
class FxBasisHelper {
-layoutId: Int
}
note for FxBasisHelper "FxBasisHelper现在是抽象的"
文件级更改
提示和命令与Sourcery互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR introduces version 2.3.0 with two main changes: the addition of a DSL marker annotation for better type safety in the builder pattern, and implementation of a new activity lifecycle callback in the simple app example. Updated class diagram for FxBasisHelperclassDiagram
class FxBasisHelper {
-layoutId: Int
}
note for FxBasisHelper "FxBasisHelper is now abstract"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @Petterpx - 我已经审查了你的更改,它们看起来很棒!
这是我在审查期间查看的内容
- 🟡 一般问题:发现1个问题
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击👍或👎,我将使用反馈来改进你的审查。
Original comment in English
Hey @Petterpx - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -46,6 +49,12 @@ object FxAppSimple { | |||
) | |||
}, | |||
) | |||
setTagActivityLifecycle(object :IFxProxyTagActivityLifecycle{ | |||
override fun onDestroyed(activity: Activity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议: 删除仅调用super的空覆盖
此覆盖除了super调用外没有添加任何功能。要么添加清理逻辑,要么完全删除覆盖
setTagActivityLifecycle(object :IFxProxyTagActivityLifecycle{
})
Original comment in English
suggestion: Remove empty override that only calls super
This override adds no functionality beyond the super call. Either add cleanup logic or remove the override entirely
setTagActivityLifecycle(object :IFxProxyTagActivityLifecycle{
})
Summary by Sourcery
通过在各种接口和类中引入FxBuilderDsl注解来增强DSL支持。将FxBasisHelper更改为抽象类以提高抽象性。修复英文README中的表格格式以提高可读性。
增强功能:
文档:
Original summary in English
Summary by Sourcery
Enhance the DSL support by introducing the FxBuilderDsl annotation to various interfaces and classes. Change FxBasisHelper to an abstract class to improve abstraction. Fix table formatting in the English README for better readability.
Enhancements:
Documentation: