From 4a571289abc3ca30782b64acab1827e2c6fdf03e Mon Sep 17 00:00:00 2001 From: jamesharrow <93921463+jamesharrow@users.noreply.github.com> Date: Thu, 3 Oct 2024 13:25:33 +0100 Subject: [PATCH] Apply suggestions from code review Fixed step numbers being out and made PICS F00(EnergyManagement) / F01(TankPercentage) to be more in line with the test plan. --- src/python_testing/TC_EWATERHTR_2_1.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/python_testing/TC_EWATERHTR_2_1.py b/src/python_testing/TC_EWATERHTR_2_1.py index 3c21f7ef230fec..e9ae195f98566c 100644 --- a/src/python_testing/TC_EWATERHTR_2_1.py +++ b/src/python_testing/TC_EWATERHTR_2_1.py @@ -99,14 +99,14 @@ async def test_TC_EWATERHTR_2_1(self): if em_supported: value = await self.read_whm_attribute_expect_success(attribute="TankVolume") else: - logging.info("Skipping step 4 as PICS.EWATERHTR.EM not supported") + logging.info("Skipping step 5 as PICS.EWATERHTR.F00(EnergyManagement) not supported") self.step("6") if em_supported: value = await self.read_whm_attribute_expect_success(attribute="EstimatedHeatRequired") asserts.assert_greater_equal(value, 0, f"Unexpected EstimatedHeatRequired value - expected {value} >= 0") else: - logging.info("Skipping step 5 as PICS.EWATERHTR.EM not supported") + logging.info("Skipping step 6 as PICS.EWATERHTR.F00(EnergyManagement) not supported") self.step("7") if tp_supported: @@ -114,7 +114,7 @@ async def test_TC_EWATERHTR_2_1(self): asserts.assert_greater_equal(value, 0, f"Unexpected TankPercentage value - expected {value} >= 0") asserts.assert_less_equal(value, 100, f"Unexpected TankPercentage value - expected {value} <= 100") else: - logging.info("Skipping step 6 as PICS.EWATERHTR.TP not supported") + logging.info("Skipping step 7 as PICS.EWATERHTR.F01(TankPercenage) not supported") self.step("8") boost_state = await self.read_whm_attribute_expect_success(attribute="BoostState")