Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild path lookup should work with only VS 2017 installed #109

Open
Hafeok opened this issue Oct 20, 2017 · 2 comments
Open

MSBuild path lookup should work with only VS 2017 installed #109

Hafeok opened this issue Oct 20, 2017 · 2 comments
Labels
bug enhancement help wanted

Comments

@Hafeok
Copy link
Contributor

Hafeok commented Oct 20, 2017

User story

As a developer, I want to use the generator with only Visualstudio 2017 installed so that i dont need more than one tool installed (Please replace the <> areas and remove this parentheses)

Expected behavior

The generator works with only Visual Studio 2017 installed.

Actual behavior

The generator needs an MSbuild installed from before 2015 in order for the Get-MSBuild path powershell function to return the proper path.

Steps to reproduce the behavior

See issue #107
@TakeitEasyAlan
Copy link
Member

I believe we should remove the lookup

@TakeitEasyAlan
Copy link
Member

Looking at the usages, we can solve this by simply including Microsoft.Build.dll in the generator module.
#107 #118

This was referenced Nov 16, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hafeok @TakeitEasyAlan