Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added check that niwot.out hasn't changed to github actions #18

Merged
merged 9 commits into from
Aug 19, 2024
Merged

added check that niwot.out hasn't changed to github actions #18

merged 9 commits into from
Aug 19, 2024

Conversation

dlebauer
Copy link
Member

Following up on #17, adds check that niwot.out hasn't changed using git diff --exit-code

@dlebauer dlebauer requested a review from Alomir August 16, 2024 20:17
@dlebauer dlebauer mentioned this pull request Aug 16, 2024
Closed
@dlebauer dlebauer closed this Aug 16, 2024
@dlebauer dlebauer reopened this Aug 16, 2024
@dlebauer dlebauer closed this Aug 17, 2024
@dlebauer dlebauer reopened this Aug 17, 2024
@dlebauer dlebauer closed this Aug 17, 2024
@dlebauer dlebauer reopened this Aug 17, 2024
@dlebauer dlebauer closed this Aug 17, 2024
@dlebauer dlebauer reopened this Aug 17, 2024
dlebauer
dlebauer commented Aug 17, 2024
View reviewed changes
@dlebauer
Copy link
Member Author

git diff --exit-code errored on windows, so excluded it from that job

@Alomir
Copy link
Contributor

Alomir commented Aug 17, 2024

Maintaining compatibility with Windows will be a never-ending morass of issues; I'm fine with removing the check here.

Alomir
Alomir approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm fine with removing anything beyond strict existence checks from Windows (and even that we might want to drop)

@dlebauer dlebauer merged commit db537b7 into master Aug 19, 2024
4 checks passed
@dlebauer dlebauer deleted the 15_check_output branch August 19, 2024 16:08
dlebauer added a commit that referenced this pull request Aug 19, 2024
@dlebauer
remove windows from Sipnet CI
7416460 
While implementing & reviewing #17 and #18 it became clear that supporting Windows builds would require a lot of exceptions. Given that Windows Subsystem for Linux provides a viable option for Windows users this PR proposes removing support for windows builds.
@dlebauer dlebauer mentioned this pull request Aug 19, 2024
Merged
@dlebauer
Copy link
Member Author

added removing windows to #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alomir Alomir Alomir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlebauer @Alomir