add logging to assertPassesWithMultipleAttempts

Parsely · Aug 2, 2012 · 8a3f822 · 8a3f822
1 parent 4ff051b
commit 8a3f822
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/tests/logging.conf → tests/debug-logging.conf b/tests/logging.conf → tests/debug-logging.conf
diff --git a/tests/samsa/client/tests.py b/tests/samsa/client/tests.py
@@ -14,13 +14,16 @@
 limitations under the License.
 """
 
+import logging
 import time
 
 from samsa.client import Client, Message, OFFSET_EARLIEST, OFFSET_LATEST
 from samsa.test.integration import (KafkaIntegrationTestCase,
     ManagedConsumer, ManagedProducer)
 
 
+logger = logging.getLogger(__name__)
+
 # class ClientTestCase(unittest2.TestCase):
 #     def test_produce(self):
 #         raise NotImplementedError
@@ -58,12 +61,17 @@ def assertPassesWithMultipleAttempts(self, fn, attempts, timeout=1, backoff=None
             backoff = lambda attempt, timeout: timeout
 
         for attempt in xrange(1, attempts + 1):
+            logger.debug('Starting attempt %s for %s...', attempt, fn)
             try:
                 fn()
+                logger.info('Passed attempt %s for %s', attempt, fn)
                 break
             except AssertionError:
                 if attempt < attempts:
-                    time.sleep(backoff(attempt, timeout))
+                    wait = backoff(attempt, timeout)
+                    logger.exception('Failed attempt %s for %s, waiting for %s seconds',
+                        attempt, fn, wait)
+                    time.sleep(wait)
                 else:
                     raise