Skip to content
This repository was archived by the owner on Mar 24, 2021. It is now read-only.

Commit

Permalink
lint hates local function definition
Browse files Browse the repository at this point in the history
  • Loading branch information
tkaemming committed Aug 1, 2012
1 parent 0e4d603 commit 4ff051b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/samsa/client/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,14 @@ def ensure_valid_response():
payloads = ['hello', 'world']
producer.publish(payloads)

def ensure_valid_response():
def ensure_valid_response_again():
messages = list(self.kafka.fetch(topic, 0, self.offset, size))
self.assertEqual(len(messages), 2)
self.assertTrue(all(isinstance(m, Message) for m in messages))
self.assertEqual([m.payload for m in messages], payloads)
self.assertEqual(messages[0].offset, self.offset)

self.assertPassesWithMultipleAttempts(ensure_valid_response, 5)
self.assertPassesWithMultipleAttempts(ensure_valid_response_again, 5)

producer.stop()

Expand Down Expand Up @@ -195,7 +195,7 @@ def ensure_valid_response():
producer.publish(payloads)
batches.append((topic, 0, self.next_offsets[topic], size))

def ensure_valid_response():
def ensure_valid_response_again():
responses = self.kafka.multifetch(batches)
for topic, response in zip(topics, responses):
messages = list(response)
Expand All @@ -206,7 +206,7 @@ def ensure_valid_response():
self.assertEqual([m.payload for m in messages],
[payload_for_topic(topic)] * num_messages)

self.assertPassesWithMultipleAttempts(ensure_valid_response, 5)
self.assertPassesWithMultipleAttempts(ensure_valid_response_again, 5)

for producer in producers.values():
producer.stop() # todo: thread pooling or something
Expand Down

0 comments on commit 4ff051b

Please sign in to comment.