New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more conventional TS style in packages/scripts #313

Merged

Eric-Arellano merged 3 commits into ParkingReformNetwork:main from Eric-Arellano:EA/refactor-scripts

Jan 11, 2025

Contributor

Eric-Arellano commented Jan 11, 2025

Using ts-results didn't make much sense because we weren't doing anything interesting with the results, such as deferring erroring. We wanted to error immediately. It added indirection
I'm not sure why I was using anonymous functions rather than function
I like putting export directly on the function rather than the bottom of the file

Eric-Arellano added 3 commits

January 11, 2025 16:50


          Use more conventional TS style in packages/scripts

9dc0873


          Fix tests

4f9c8a3


          Fix lint

ccb39e8

Eric-Arellano merged commit e18a90a into ParkingReformNetwork:main

1 check passed

Eric-Arellano deleted the EA/refactor-scripts branch

January 11, 2025 22:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet