Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If configPath not found, log actual failed path #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charneykaye
Copy link

@charneykaye charneykaye commented Jan 26, 2024

It turns out, the configPath value gets appended to the value of the GitHub environment variable GITHUB_WORKSPACE when present, e.g. /home/runner/work/myappname/myappname such that configPath in that case must begin with a slash, or else the concatenation results in an invalid path.

Recommend that the error message from this library show the actual path checked for a file on failure.

Relates to #15

@charneykaye charneykaye marked this pull request as draft January 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant