Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign: hyemi #67

Open
wants to merge 191 commits into
base: master
Choose a base branch
from
Open

Add sign: hyemi #67

wants to merge 191 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2019

No description provided.

cdy0510 and others added 30 commits October 11, 2019 13:37
Signing the guestbook! :)
DEVFEST이미지 추가, 문구 수정, 페이스북 링크 추가
안내 문구 한글번역
base repository에 있던 방명록 삭제
새로운 방명록 작성
개인 repo만든 상태에서 upstream(GDG-Seoul)로 이동하여 PR 생성시  PandelisZ/workshop-guestbook 쪽이 base로 PR이 생성됩니다.
환경차이가 있을 수 있겠지만 개인 repo에서 PR 생성시 GDG 쪽으로 PR이 생성되는걸 확인했습니다.
PR에 익숙하지 않은분들을 고려하여 개인 저장소에서 PR을 생성하는쪽이 좋을거같습니다.
포크 버튼 추가 제안
Shinye and others added 29 commits October 20, 2019 14:03
Create dahee.yaml
Create guestbook yaml files
이모지는 한개만 사용 가능합니다
@TravisBuddy
Copy link

Travis tests have failed

Hey @hyeguiee,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.3.1

View build log

yamllint _guestbook/*
_guestbook/beomjun.yaml
  5:81      warning  line too long (131 > 80 characters)  (line-length)

_guestbook/dayoung.yaml
  5:81      warning  line too long (93 > 80 characters)  (line-length)

_guestbook/gyeongseon.yaml
  5:81      warning  line too long (92 > 80 characters)  (line-length)
  7:10      warning  too many spaces before colon  (colons)

_guestbook/haenara.yaml
  5:81      warning  line too long (107 > 80 characters)  (line-length)

_guestbook/haesunpark.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)
  8:9       error    trailing spaces  (trailing-spaces)

_guestbook/hyemi.yaml
  6:10      error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/imjmo.yaml
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/jakeyoo.yaml
  6:81      warning  line too long (140 > 80 characters)  (line-length)

_guestbook/JieunJang.yaml
  1:4       error    trailing spaces  (trailing-spaces)
  3:53      error    trailing spaces  (trailing-spaces)
  4:12      error    trailing spaces  (trailing-spaces)
  6:10      error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)
  8:10      warning  too many spaces before colon  (colons)

_guestbook/jihunchoi.yaml
  1:4       error    trailing spaces  (trailing-spaces)
  2:16      error    trailing spaces  (trailing-spaces)
  3:53      error    trailing spaces  (trailing-spaces)
  4:12      error    trailing spaces  (trailing-spaces)

_guestbook/jinnybrain.yaml
  7:9       error    trailing spaces  (trailing-spaces)
  8:8       error    trailing spaces  (trailing-spaces)

_guestbook/jiyeonlee.yaml
  5:32      error    trailing spaces  (trailing-spaces)

_guestbook/junil.yaml
  6:10      error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/juwon.yaml
  2:5       warning  too many spaces before colon  (colons)
  3:7       warning  too many spaces before colon  (colons)
  4:6       warning  too many spaces before colon  (colons)
  5:8       warning  too many spaces before colon  (colons)
  6:9       warning  too many spaces before colon  (colons)
  7:7       warning  too many spaces before colon  (colons)

_guestbook/kimjaehyeok.yaml
  5:81      warning  line too long (90 > 80 characters)  (line-length)

_guestbook/Leesangik.yaml
  4:12      error    trailing spaces  (trailing-spaces)

_guestbook/narashin.yaml
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/neulbo27.yaml
  7:4       error    no new line character at the end of file  (new-line-at-end-of-file)

_guestbook/SambaLim.yaml
  1:4       error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/seongwon-kang.yaml
  1:1       error    missing document start "---"  (document-start)

_guestbook/SeunghyunEom.yaml
  1:1       error    missing document start "---"  (document-start)
  6:9       error    trailing spaces  (trailing-spaces)

_guestbook/ShimSeokbo.yaml
  5:81      warning  line too long (121 > 80 characters)  (line-length)

_guestbook/shinye.yaml
  5:81      warning  line too long (134 > 80 characters)  (line-length)

_guestbook/skile.yaml
  1:1       error    missing document start "---"  (document-start)

_guestbook/SoohyeonPark
  1:4       error    trailing spaces  (trailing-spaces)
  4:12      error    trailing spaces  (trailing-spaces)

_guestbook/soojung.yaml
  1:4       error    trailing spaces  (trailing-spaces)
  4:12      error    trailing spaces  (trailing-spaces)

_guestbook/space.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)
  8:9       error    trailing spaces  (trailing-spaces)

_guestbook/sumin-choi.yaml
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/wone2287.yaml
  6:10      error    trailing spaces  (trailing-spaces)

_guestbook/woosik.yaml
  1:4       error    trailing spaces  (trailing-spaces)
  3:53      error    trailing spaces  (trailing-spaces)
  4:12      error    trailing spaces  (trailing-spaces)
  5:47      error    trailing spaces  (trailing-spaces)
  6:15      error    trailing spaces  (trailing-spaces)

_guestbook/yebin.yaml
  5:81      warning  line too long (85 > 80 characters)  (line-length)

_guestbook/yjkim.yaml
  6:10      error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/ywkim.yaml
  6:10      error    trailing spaces  (trailing-spaces)
  7:9       error    trailing spaces  (trailing-spaces)

_guestbook/zuyoungpark.yaml
  2:5       error    syntax error: mapping values are not allowed here
ruby -Itest tests/tests.rb
Loaded suite tests/tests
Started
F
================================================================================
Failure:
  opening --- missing: ./_guestbook/skile.yaml.
  <false> is not true.
test_frontmattervalidation(TestFrontMatterValidation)
tests/tests.rb:13:in `block in test_frontmattervalidation'
     10:             keys = data.keys.map { |k| k.downcase }
     11:             assert(keys.include?("name"), "name missing: #{path}")
     12:             lines = File.readlines(path)
  => 13:             assert("---\n" == lines[0], "opening --- missing: #{path}")
     14:             assert(lines[4..-1].include?("---\n"), "closing --- missing: #{path}")
     15:         end
     16:     end
tests/tests.rb:7:in `each'
tests/tests.rb:7:in `test_frontmattervalidation'
================================================================================


Finished in 0.008851778 seconds.
--------------------------------------------------------------------------------
1 tests, 35 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
--------------------------------------------------------------------------------
112.97 tests/s, 3954.01 assertions/s
TravisBuddy Request Identifier: ebc000a0-f2fc-11e9-a94e-c51b88d78b8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.