-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Access Key API Methods #88
base: master
Are you sure you want to change the base?
chore: Add Access Key API Methods #88
Conversation
@AnushreeHS can i get a review on this? |
@AnushreeHS any updates on this? I see you actively merging other PRs. |
Hi @hi-artem Thank you for your contribution. While the pull request addresses part of the feature, further implementation of the resource and data source is necessary to fully support it. We appreciate your effort and will plan to implement this feature. |
@hi-artem After review, the team has determined that this approach raises concerns both regarding persistence of secret material and that the idempotency of the resulting resources. As a result, the recommendation for automated Access Key Management at this time is to work directly with the Access Key API to integrate with the secrets manager of your choice. |
@AnushreeHS I can implement the terraform provider support once this is merged. You can see my contributions to https://github.com/PaloAltoNetworks/terraform-provider-prismacloudcompute/graphs/contributors to get my prior experience. I am currently waiting on merging this pull requests so I can start updating the provider. Thank you. |
@ftbrecordspan can you elaborate on the issue using Terraform provider to provision keys? IMO it is better for you as a vendor to implement this feature in the Terraform provider safely, rather than leave it as customer responsibility. Furthermore, this is a blocker for people using Terraform and wanting to manage keys in automated manner. Looking forward to your response. |
Description
See this for reference: https://pan.dev/prisma-cloud/api/cspm/access-keys/
Examples:
Motivation and Context
Blocks PaloAltoNetworks/terraform-provider-prismacloud#295
How Has This Been Tested?
See above
Checklist