Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: migrate the file test/graphql/types/Mutation/deleteAgendaItem.test.ts to integration test #3270

Closed
Piyushk8 opened this issue Feb 21, 2025 · 3 comments
Assignees
Labels
bug Something isn't working security Security fix test Testing application

Comments

@Piyushk8
Copy link

Describe the bug

The deleteAgendaItem GraphQL mutation (in test/graphql/types/Mutation/deleteAgendaItem) uses mocked tests, contradicting the project's requirement for integration testing via real API calls for all mutations in that directory. These mutation files are also incorrectly located; they belong in test/routes/Graphql/Mutation/*.

Expected Behavior

All GraphQL mutations, including deleteAgendaItem, should be thoroughly integration tested using actual API calls. Mutation files should reside in test/routes/Graphql/Mutation/*.

Actual Behavior

deleteAgendaItem uses mocked tests, bypassing the real API and services. The file is in the wrong directory.

Impact

Mocked tests provide a false sense of security, risking undetected bugs and regressions. Inconsistent testing hinders maintainability.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Piyushk8 Piyushk8 added the bug Something isn't working label Feb 21, 2025
@github-actions github-actions bot added security Security fix test Testing application unapproved Unapproved for Pull Request labels Feb 21, 2025
@im-vedant
Copy link

@varshith257 assign

@Cioppolo14
Copy link
Contributor

@Piyushk8 Did you want to be assigned this?

@Piyushk8
Copy link
Author

No, you can assign this to anyone

@Piyushk8 Did you want to be assigned this?

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Feb 22, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-API (Tests) Feb 23, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in NoMongo: Talawa-API Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security Security fix test Testing application
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants