-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMongo: GitHub action to test basic DB access and updates #3214
Comments
@palisadoes please assign |
@palisadoes please assign. |
Thankyou @dhanagopu |
When the containers start the |
@palisadoes No sir Every user should have unique user_id, if we try to use sample data script two times, it was conflicting earlier due to this, I have fixed that thing, now it will not throw error on this. rather if that particular sample data is already present, it will continue adding other data sample data script is never designed to add API_ADMINISTRATOR_USER in the first place, it was other data that was conflicting which has been fixed, |
Sample data script will not run if API_ADMINISTRATOR_USER is not present, that's why I used seedInitialData helper function here to deal with cases when db is reset intentionally and then user tries to add sample data, then administrator will be recreated, sample data has nothing to do with administrator I strongly recommend you to try executing sample data and reset scripts in all cases, you'll find out whatever user does like format db, change administrator or change sample data anything, they will not throw error and fulfill their purpose |
Sir this issue is not related to this, this issue is long existing but came to picture right now since bucket problem solved. https://palisadoes-foundation.slack.com/archives/CSWH4PN0M/p1738240831597849 For clarity, I added support of pnpm and node to all shells + which already had it. |
I ran it and it works. |
What is causing the error
PTAL. This is what I was referring to. I had to revert your PR. |
Sir that message is logged by me .. for clarity |
It is not an error |
It is a check to avoid errors in future if someone by mistake resets database then access will be lost, it is a fail safe thing |
You are misinterpreting two issues.
|
Sir I got your point |
That error is just due to 2 files integration testing on same database. |
Just give me few minutes I'll fix this |
Actually the problem is that file is creating administrator at same time in test when I am testing creating administrator after a db reset |
Why did you have to add the path for fnm in the docker file? If fnm installed, couldn't you just run fnm to install the version of node in the ENV variable and then pnpm? I'm wondering whether your solution could fail in other operating systems (unlikely) The solution you chose seems too dependent on the location of hidden files. There must be a more conventional way where a symlink is created to the pnpm location by the fnm team verus us. For example sym linking from /usr/bin/pnpm If fnm changes it's methodology then the installation could break. |
Agreed |
Is your feature request related to a problem? Please describe.
Our GitHub actions test basic functionality, but don't test key functionalities on live data.
Describe the solution you'd like
Create GitHub actions that test the importation of sample data
Depends on:
Describe alternatives you've considered
Approach to be followed (optional)
Additional context
Depends on:
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: