Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect event topic for chat message deletion #3202

Open
coderabbitai bot opened this issue Feb 12, 2025 · 3 comments
Open

Fix: Incorrect event topic for chat message deletion #3202

coderabbitai bot opened this issue Feb 12, 2025 · 3 comments
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2025

The event topic in deleteChatMessage resolver uses ':chat_messages::create' for deletion operations, which is incorrect and could cause confusion for subscribers.

Current Behavior

The current implementation publishes deletion events with topic 'chats.[chatId]:chat_messages::create'

Expected Behavior

Deletion events should use topic 'chats.[chatId]:chat_messages::delete' to accurately reflect the operation type.

Context

This should be addressed in a separate PR focused on server-side improvements.

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Feb 12, 2025
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@CHIRANTH-24
Copy link

Can I work on this issue?

@iamanishx
Copy link

this hasn't been approved yet ig not a valid issue by rabbitai . wait for checks

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants