camera_manager_plugin: fix mavlink messages for camera info and video stream information #1051
Conversation
… stream information This time with structs instead of the direct pack_chan() calls that might break again quickly.
| video_stream_information.hfov = 90; // made up | ||
| std::strcpy(video_stream_information.name, "Visual Spectrum"); | ||
| std::strcpy(video_stream_information.uri, _videoURI.c_str()); | ||
|
|
There was a problem hiding this comment.
Note, there is a new encoding field, which ideally you should set to VIDEO_STREAM_ENCODING_H264. If you don't it won't matter because the default value 0 means "don't know" and the recipient should detect. This is to reduce effort on recipient as cameras start to encode in H265.
There was a problem hiding this comment.
You're probably right, didn't even check what should be set in the extension 😇
I added it in 357396f
This will probably make CI fail again because the extension does not yet exist on PX4 main until PX4/PX4-Autopilot#23490 is merged...
|
The build on this side is broken. |
|
FYI @julianoes This is touching the new camera ids. |
|
FYI: you can always just set extensions to 0 if you don't want to do the work to use them yet. |
…ncpy with destination size, set H264 encoding
I don't understand if and why it's necessary but found a way to do it with the struct encode method.
|
Let's skip the new fields and get this through.
|
Problem
Can't update MAVLink in PX4 anymore because of
mavlink/mavlink#2121
mavlink/mavlink#2127
which are not breaking changes but because of the way they are invoked here end up breaking the build
which makes CI in PX4/PX4-Autopilot#23490 fail.
Solution
Like proposed by @dagar this time I fix it with the struct call instead of the direct pack_chan() calls. So it should hold longer.
Please check if I did any mistake with these string, component ID and MAVLink channel things. What was
MAVLINK_COMM_1used for?