Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert Census-year assumption to 2010 and revise associated comment #244

Closed

Conversation

donboyd5
Copy link
Collaborator

Addresses #242

@donboyd5 donboyd5 requested a review from martinholmer October 19, 2024 14:21
@donboyd5
Copy link
Collaborator Author

@martinholmer

Am trying to create a valid PR that will address #242

Have not been able to get permissions for the PUF 2015 - see error report below from Pull request / Test (pull_request). I did add the two access tokens to my fork's repository secrets (see first screenshot below) but when I then edit a secret it does not show (see 2nd screenshot). Perhaps I have not done it properly.

Would you be able to review and merge the PR? Any advice an how I can get my PR's to have proper permissions for the PUF 2015?

image

image

    puf_2015 = download_gh_release_asset(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/tax-microdata-benchmarking/tax-microdata-benchmarking/tmd/utils/cloud.py", line 62, in download_gh_release_asset
    "id" in releases
AssertionError: Release tmd-prerequisites not found. Available releases: {'message': 'Bad credentials', 'documentation_url': 'https://docs.github.com/rest', 'status': '401'}
make: *** [Makefile:4: install] Error 1
Error: Process completed with exit code 2.

@martinholmer
Copy link
Collaborator

@donboyd5, I don't know what is wrong with your PR #244.
Does my yesterday suggestion not work?

@donboyd5
Copy link
Collaborator Author

Thanks, @martinholmer. It does work, but I had already created a local branch that does what I need so I went with that. All good. Thanks for following up.

@donboyd5
Copy link
Collaborator Author

donboyd5 commented Oct 20, 2024

Eventually I'll figure out why I don't have the right permissions for the PUF for purposes of pull requests, and will try to fix it. I tried for an hour or two yesterday, getting advice from ChatGPT, but I still didn't figure it out. I'll work on it after Phase 4.

@martinholmer
Copy link
Collaborator

Proposed changes in this PR were included in merged PR #251.

@donboyd5 donboyd5 deleted the revert-to-117th-congress-updated branch October 31, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants