After sign in path #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavis
commented
May 9, 2025
| @@ -44,6 +44,7 @@ def prx_authenticated? | |||
|
|
|||
| def authenticate! | |||
| if !current_user | |||
| set_after_sign_in_path | |||
There was a problem hiding this comment.
Previously, we were setting this session key on basically every request. Which included a bunch of "turbo preloading" of links when you just hover over them!
Now, we just explicitly set it just before we redirect to the sessions controller.
| @@ -70,6 +70,7 @@ def refresh | |||
| sign_out_user | |||
| session[WILDCARD_SESSION_KEY] = wildcard | |||
|
|
|||
| set_after_sign_in_path(request.referer.presence || "/") | |||
There was a problem hiding this comment.
And here's the 2nd place to set it... admins request wildcard access by clicking a link /auth/sessions/refresh?wildcard=true. So in this case, we grab the referrer, and send them back there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.
As a bonus, handle nil
ID_HOSTs, so you can run a test suite without needing to set that. (Myconfig/prx_auth.rbinitializer was erroring).