Skip to content

Commit de0c2e9

Browse files
committed
patch non pagebuilder content
1 parent 96f1de0 commit de0c2e9

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

components/Product/Product.styled.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,15 @@ export const Images = styled.div`
4646
export const Image = styled(ImageComponent)`
4747
width: 100%;
4848
height: 100%;
49-
object-fit: cover;
49+
object-fit: contain;
5050
object-position: center;
51+
max-height: 70vh;
52+
5153
filter: unset;
5254
5355
@media ${props => props.theme.breakpoints.smallOnly} {
5456
max-height: 70vh;
57+
object-fit: cover;
5558
}
5659
`
5760

components/Product/Product.tsx

+7-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import Breadcrumbs from '@storystore/ui/dist/components/Breadcrumbs'
1414
import PageBuilder from '~/components/PageBuilder'
1515
import useHtml from '~/hooks/useHtml'
1616
import { OtherProducts } from './OtherProducts'
17+
import { isPageBuilderHtml } from '../PageBuilder/lib/utils'
1718

1819
const SimpleProduct = dynamic(() => import('./ProductTypes/SimpleProduct'))
1920
const GroupedProduct = dynamic(() => import('./ProductTypes/GroupedProduct'))
@@ -132,6 +133,8 @@ export const Product: FunctionComponent<QueryResult> = ({ loading, data }) => {
132133
)
133134
}
134135

136+
const isDescriptionPageBuilder = product?.description?.html ? isPageBuilderHtml(product.description.html) : false
137+
135138
return (
136139
<ProductContext.Provider value={{ setPrice: handleUpdatePrice, setGallery: handleUpdateGallery }}>
137140
{product && <Head title={product.metaTitle || product.title} description={product.metaDescription} keywords={product.metaKeywords} />}
@@ -191,15 +194,17 @@ export const Product: FunctionComponent<QueryResult> = ({ loading, data }) => {
191194
{/* TODO: ... */}
192195
{product.type === 'GiftCard' && <GiftCard {...product} />}
193196

194-
{product.descriptionContainer === 'container1' && product?.description?.html && <Description as={PageBuilder} html={product.description.html} />}
197+
{(product.descriptionContainer === 'container1' || !isDescriptionPageBuilder) && product?.description?.html && (
198+
<Description as={PageBuilder} html={product.description.html} />
199+
)}
195200
</React.Fragment>
196201
)}
197202
</Info>
198203
</InfoInnerWrapper>
199204
</InfoWrapper>
200205
</Wrapper>
201206

202-
{product?.descriptionContainer === 'container2' && product?.description?.html && <Description as={PageBuilder} html={product.description.html} />}
207+
{product?.descriptionContainer === 'container2' && isDescriptionPageBuilder && product?.description?.html && <Description as={PageBuilder} html={product.description.html} />}
203208

204209
{product?.urlKey && <OtherProducts urlKey={product.urlKey} />}
205210
</Root>

0 commit comments

Comments
 (0)