Addressed compatibility issue of OpenPNM with numpy 2.2 #2958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With NumPy 2.2, the reshape function signature has changed:
https://numpy.org/doc/stable/reference/generated/numpy.reshape.html
The provided array is now a positional-only argument and the
newshape
parameter is deprecated in favor ofshape
.This affected the following files:
openpnm/_skygraph/queries/_funcs.py
openpnm/io/_pergeos.py
Fix:
Scanned the whole repository for affected calls, found and fixed following occurrences
temp
toa
in the reshape call inopenpnm/_skygraph/queries/_funcs.py
line 167newshape
parameter and use positional arguments for compatibility of numpy versions inopenpnm/_skygraph/queries/_funcs.py
line 167 andopenpnm/io/_pergeos.py
line 178Note: