Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from jest to vitest #264

Merged
merged 9 commits into from
Dec 5, 2023
Merged

Switch from jest to vitest #264

merged 9 commits into from
Dec 5, 2023

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Nov 14, 2023

Abstract

Jest had some problems, like not supporting ES6 by default and having to mock some modules to make it run.
Vitest works much better out of the box, and doesn't require anything else, like the babel dependency.

TrasnferMenu tests were also added, to check for automatic price update, and the close and send event

Testing

No testing is required

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit fbc3df3
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6565a5582e315800084ec6ae
😎 Deploy Preview https://deploy-preview-264--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

panleone
panleone previously approved these changes Nov 15, 2023
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4ead1f9

this new frameworks looks much better than jest

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tACK fd738fd

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK fbc3df3
Framework looks to be better suited to our needs good deal

@panleone panleone merged commit fd69fae into PIVX-Labs:master Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants