Generic/DisallowShortOpenTag: prevent fixer conflict #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original fixer conflict which inspired this fix can be reproduced via: ```bash phpcbf -ps ./src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.19.inc --report=full,source --suffix=.fixed --standard=Squiz ``` What it basically comes down to is that this sniff would replace the `<?=` with `<?php echo`, even in case of a parse error, which would then cause problems for other sniffs. Fixed now by ignoring this particular parse error. Includes test. Note: this PR will be most straight-forward to review while ignoring whitespace changes.
jrfnl
deleted the
feature/generic-disallowshortopentag-dont-act-on-parse-error
branch
jrfnl
added a commit
that referenced
this pull request
Mar 3, 2025
The original fixer conflict which inspired this fix can be reproduced via: ```bash phpcbf -ps ./src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.19.inc --report=full,source --suffix=.fixed --standard=Squiz ``` What it basically comes down to is that this sniff would replace the `<?=` with `<?php echo`, even in case of a parse error, which would then cause problems for other sniffs. Fixed now by ignoring this particular parse error. Includes test. Note: this PR will be most straight-forward to review while ignoring whitespace changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original fixer conflict which inspired this fix can be reproduced via:
What it basically comes down to is that this sniff would replace the
<?=with<?php echo, even in case of a parse error, which would then cause problems for other sniffs.Fixed now by ignoring this particular parse error.
Includes test.
Note: this PR will be most straight-forward to review while ignoring whitespace changes.
Suggested changelog entry
Generic.PHP.DisallowShortOpenTag: don't act on parse errors
Related issues/external references
Related to #152
Types of changes