Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Better libxml2 tests #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests: Better libxml2 tests #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 59 additions & 3 deletions tests/Core/Ruleset/ProcessRulesetBrokenRulesetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,15 @@ final class ProcessRulesetBrokenRulesetTest extends AbstractRulesetTestCase
*/
public function testBrokenRulesetEmptyFile()
{
if (version_compare(LIBXML_DOTTED_VERSION, '2.12.0', '>=') === false) {
$this->markTestSkipped('Test requires libxml2 2.12.0 or higher');
}

$standard = __DIR__.'/ProcessRulesetBrokenRulesetEmptyFileTest.xml';
$config = new ConfigDouble(["--standard=$standard"]);

$regex = '`^Ruleset \S+ProcessRulesetBrokenRulesetEmptyFileTest\.xml is not valid\R';
$regex .= '(- On line 1, column 1: Document is empty\R)?$`';
$regex .= '- On line 1, column 1: Document is empty\R$`';

$this->expectRuntimeExceptionRegex($regex);

Expand All @@ -49,6 +53,29 @@ public function testBrokenRulesetEmptyFile()
}//end testBrokenRulesetEmptyFile()


/**
* Test displaying an informative error message when an empty XML ruleset file is encountered.
*
* @return void
*/
public function testBrokenRulesetEmptyFileWithOldLibxml2()
{
if (version_compare(LIBXML_DOTTED_VERSION, '2.12.0', '<') === false) {
$this->markTestSkipped('Test requires libxml2 < 2.12.0');
}

$standard = __DIR__.'/ProcessRulesetBrokenRulesetEmptyFileTest.xml';
$config = new ConfigDouble(["--standard=$standard"]);

$regex = '`^Ruleset \S+ProcessRulesetBrokenRulesetEmptyFileTest\.xml is not valid\R$`';

$this->expectRuntimeExceptionRegex($regex);

new Ruleset($config);

}//end testBrokenRulesetEmptyFileWithOldLibxml2()


/**
* Test displaying an informative error message for a broken XML ruleset with a single XML error.
*
Expand Down Expand Up @@ -76,13 +103,16 @@ public function testBrokenRulesetSingleError()
*/
public function testBrokenRulesetMultiError()
{
if (version_compare(LIBXML_DOTTED_VERSION, '2.12.0', '>=') === false) {
$this->markTestSkipped('Test requires libxml2 >= v2.12.0');
}

$standard = __DIR__.'/ProcessRulesetBrokenRulesetMultiErrorTest.xml';
$config = new ConfigDouble(["--standard=$standard"]);

$regex = '`^Ruleset \S+ProcessRulesetBrokenRulesetMultiErrorTest\.xml is not valid\R';
$regex .= '- On line 8, column 12: Opening and ending tag mismatch: property line 7 and rule\R';
$regex .= '- On line 10, column 11: Opening and ending tag mismatch: properties line 5 and ruleset\R';
$regex .= '(- On line 11, column 1: Premature end of data in tag rule line 4\R)?$`';
$regex .= '- On line 10, column 11: Opening and ending tag mismatch: properties line 5 and ruleset\R$`';

$this->expectRuntimeExceptionRegex($regex);

Expand All @@ -91,4 +121,30 @@ public function testBrokenRulesetMultiError()
}//end testBrokenRulesetMultiError()


/**
* Test displaying an informative error message for a broken XML ruleset with multiple XML errors.
*
* @return void
*/
public function testBrokenRulesetMultiErrorWithOldLibxml2()
{
if (version_compare(LIBXML_DOTTED_VERSION, '2.12.0', '<') === false) {
$this->markTestSkipped('Test requires libxml2 < v2.12.0');
}

$standard = __DIR__.'/ProcessRulesetBrokenRulesetMultiErrorTest.xml';
$config = new ConfigDouble(["--standard=$standard"]);

$regex = '`^Ruleset \S+ProcessRulesetBrokenRulesetMultiErrorTest\.xml is not valid\R';
$regex .= '- On line 8, column 12: Opening and ending tag mismatch: property line 7 and rule\R';
$regex .= '- On line 10, column 11: Opening and ending tag mismatch: properties line 5 and ruleset\R';
$regex .= '- On line 11, column 1: Premature end of data in tag rule line 4\R$`';

$this->expectRuntimeExceptionRegex($regex);

new Ruleset($config);

}//end testBrokenRulesetMultiErrorWithOldLibxml2()


}//end class