Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Better libxml2 tests #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asispts
Copy link
Contributor

@asispts asispts commented Jan 29, 2025

Description

Follow-up #797 (review)

In this PR, I created tests for each libxml2 version. Since the issue is related to libxml2 library, we can't use @requires extension ... annotation.

Suggested changelog entry

Related issues/external references

Fixes #767

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@jrfnl
Copy link
Member

jrfnl commented Jan 29, 2025

@asispts Thank you for your willingness to contribute. Could you explain to me what the added value is of splitting the tests based on the libxml version ?

Edit: note: this PR does not address the remark which is referenced in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: make testBrokenRulesetMultiError() test compatible with LibXML 2.12+
2 participants