Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] PSR12 - Declare Statement #187

Conversation

dingo-d
Copy link
Contributor

@dingo-d dingo-d commented Dec 25, 2023

The PR contains the documentation for the PSR12/Files/DeclareStatement sniff.

Description

This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.

Suggested changelog entry

Add documentation for the PSR12 DeclareStatement sniff

Related issues/external references

Part of #148

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@jrfnl
Copy link
Member

jrfnl commented Dec 26, 2023

@dingo-d FYI: I'm going to park this PR for the time being. This sniff needs a complete rewrite, which I started a while back, but never got round to finishing. The intention is to keep the error messages and codes the same with the rewrite, but I'd rather verify the docs once I've finished the rewrite if you don't mind.

@dingo-d dingo-d marked this pull request as draft January 6, 2024 09:52
@jrfnl
Copy link
Member

jrfnl commented Mar 11, 2024

Closing - see: #148 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants