Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic/NoSilencedErrors: improve test coverage #180

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Generic/NoSilencedErrors: improve test coverage #180

merged 1 commit into from
Dec 25, 2023

Conversation

rodrigoprimo
Copy link
Contributor

@rodrigoprimo rodrigoprimo commented Dec 22, 2023 •
edited by jrfnl
Loading

Description

This PR adds two new tests to cover lines of the Generic.PHP.NoSilencedErrors that were not covered previously. One has to do with a sniff property that allows users to set this sniff as an error instead of a warning (default value), and the other with calculating $contextLength when its value should be smaller than the default value of 4.

Related issues/external references

Part of #146

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@rodrigoprimo
Generic/NoSilencedErrors: improve test coverage
3b2f88f 
This commit adds two new tests to cover lines of the
Generic.PHP.NoSiliencedErrors that were not covered previously. One has
to do with a sniff property that allows users to set this sniff as an
error instead of a warning (default value) and the other with
calculating $contextLength when its value should be smaller than the
default value of 4.
@jrfnl jrfnl added this to the 3.x Next milestone Dec 25, 2023
jrfnl
jrfnl approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rodrigoprimo and feel free to keep these type of PRs coming.

@jrfnl jrfnl merged commit 5b9078f into PHPCSStandards:master Dec 25, 2023
40 checks passed
@rodrigoprimo rodrigoprimo deleted the improve-code-coverage-no-silenced-errors branch January 2, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Standard: Generic Type: chores/QA
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigoprimo @jrfnl