Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic/OpeningBraceSameLine: improve code coverage #179

Conversation

rodrigoprimo
Copy link
Contributor

@rodrigoprimo rodrigoprimo commented Dec 22, 2023

Description

This PR improves the test code coverage for the Generic.Classes.OpeningBraceSameLine sniff. There was one line that was not exercised by tests that handle cases where the opening and closing brace for the class are on the same line as the class name.

Code coverage for this sniff before this PR:

https://coveralls.io/builds/64633848/source?filename=src%2FStandards%2FGeneric%2FSniffs%2FClasses%2FOpeningBraceSameLineSniff.php

And after this PR:

https://coveralls.io/builds/64729529/source?filename=src%2FStandards%2FGeneric%2FSniffs%2FClasses%2FOpeningBraceSameLineSniff.php

Related issues/external references

Part of #146

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

This commit improves the test code coverage for the
Generic.Classes.OpeningBraceSameLine sniff. There was one line that was
not exercised by tests that handle cases where the opening and closing
brace for the class are on the same line as the class name.
@rodrigoprimo rodrigoprimo force-pushed the improve-code-coverage-opening-brace-same-line branch from c142fa3 to 88ff4f1 Compare December 22, 2023 12:39
@jrfnl jrfnl added this to the 3.x Next milestone Dec 24, 2023
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @rodrigoprimo !

@jrfnl jrfnl merged commit 638c0d7 into PHPCSStandards:master Dec 24, 2023
37 checks passed
@rodrigoprimo rodrigoprimo deleted the improve-code-coverage-opening-brace-same-line branch March 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants