Sniff exclude-pattern not respected anymore ?

[tomasnorre]

After adjusting (1) the Sniff according to https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Coding-Standard-Tutorial#creating-the-sniff my exclude-pattern isn't respected anymore.

<rule ref="src/Sniffs/StrictTypes/ExplainStrictTypesSniff.php">
  <exclude-pattern>*/*Test\.php</exclude-pattern>
  <exclude-pattern>*/.meta/*\.php</exclude-pattern>
  <exclude-pattern>src/*</exclude-pattern>
  <exclude-pattern>contribution/*.php</exclude-pattern>
</rule>

Any suggestions what i'm doing wrong here? It was working before without the StrictTypes directory, and with PHPCS 3.9.2

1. ci: Fix strict types sniff exercism/php#857

[jrfnl]

@tomasnorre I suspect this may be a bug. I've just been running some tests and yes, it works without the StrictTypes directory, but I'm not sure why ;-)

Based on my current tests though, with the StrictTypes directory, the excludes also didn't work on PHPCS 3.9.2. Looks like this was broken in PHPCS 3.5.0.

I'm taking a deeper look now.

[jrfnl]

Actually... the problem used to be much bigger and 2/3 of the problem has already been solved in previous PHPCS versions.

This is a bug though, so could you please open a bug report for this ?

[jrfnl]

Follow up: #683 (comment)

Short answer (and solution): the included sniff still does not comply with the PHPCS naming conventions. Once it does, things work fine.

[jrfnl]

@tomasnorre If I remember correctly, your issue is now solved by the sniff following the PHPCS naming conventions. Correct ? If so, can I close this discussion ?