From a6ddc1eeed2f994a756281f29bd44078bf31d236 Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Thu, 19 Dec 2024 19:22:35 -0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com> --- src/Config.php | 6 +++--- tests/Core/Config/GeneratorArgTest.php | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Config.php b/src/Config.php index cfbae896b9..0484c1e913 100644 --- a/src/Config.php +++ b/src/Config.php @@ -204,8 +204,8 @@ class Config * - Keys: lowercase version of the generator name. * - Values: name of the generator PHP class. * - * Note: once support for PHP < 5.6 is dropped, this property should be refactored into a class - * constant. + * {@internal Once support for PHP < 5.6 is dropped, this property should be refactored into a class + * constant.} * * @var array */ @@ -1256,7 +1256,7 @@ public function processLongArgument($arg, $pos) if (isset(self::$validGenerators[$lowerCaseGeneratorName]) === false) { $validOptions = implode(', ', array_values(self::$validGenerators)); $error = sprintf( - 'ERROR: "%s" is not a valid generator. Valid options are: %s.'.PHP_EOL.PHP_EOL, + 'ERROR: "%s" is not a valid generator. The following generators are supported: %s.'.PHP_EOL.PHP_EOL, $generatorName, $validOptions ); diff --git a/tests/Core/Config/GeneratorArgTest.php b/tests/Core/Config/GeneratorArgTest.php index 72949409e9..87db8b5e26 100644 --- a/tests/Core/Config/GeneratorArgTest.php +++ b/tests/Core/Config/GeneratorArgTest.php @@ -23,7 +23,7 @@ final class GeneratorArgTest extends TestCase /** * Ensure that the generator property is set when the parameter is passed a valid value. * - * @param string $argumentValue Generator name passed in the command line. + * @param string $argumentValue Generator name passed on the command line. * @param string $expectedPropertyValue Expected value of the generator property. * * @dataProvider dataValidGeneratorNames